Merge pull request #33 from emin93/fix-yarn-post-install

Fixed Yarn Post Install issue

.gitignore

@@ -1,57 +1,2 @@
-# OSX
-#
-.DS_Store
-
-# Xcode
-#
-build/
-*.pbxuser
-!default.pbxuser
-*.mode1v3
-!default.mode1v3
-*.mode2v3
-!default.mode2v3
-*.perspectivev3
-!default.perspectivev3
-xcuserdata
-*.xccheckout
-*.moved-aside
-DerivedData
-*.hmap
-*.ipa
-*.xcuserstate
-project.xcworkspace
-
-# Android/IntelliJ
-#
-build/
-.idea
-.gradle
-local.properties
-*.iml
-
-# Visual Studio Code
-#
-.vscode/
-
-# node.js
-#
 node_modules/
-npm-debug.log
+.vscode/
-yarn-error.log
-
-# BUCK
-buck-out/
-\.buckd/
-*.keystore
-
-# fastlane
-#
-# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
-# screenshots whenever they are needed.
-# For more information about the recommended setup visit:
-# https://docs.fastlane.tools/best-practices/source-control/
-
-*/fastlane/report.xml
-*/fastlane/Preview.html
-*/fastlane/screenshots

.travis.yml

@@ -1,7 +1,9 @@
 language: node_js
 node_js:
   - "node"
-install: true
+cache:
+  directories:
+    - "node_modules"
 deploy:
   on:
     tags: true

App.tsx

@@ -4,37 +4,28 @@
  * 
  * Generated with the TypeScript template
  * https://github.com/emin93/react-native-template-typescript
+ * 
+ * @format
  */
 
-import React from 'react';
+import React, {Component} from 'react';
-import {
+import {Platform, StyleSheet, Text, View} from 'react-native';
-  Platform,
-  StyleSheet,
-  Text,
-  View
-} from 'react-native';
 
 const instructions = Platform.select({
-  ios: 'Press Cmd+R to reload,\n' +
+  ios: 'Press Cmd+R to reload,\n' + 'Cmd+D or shake for dev menu',
-    'Cmd+D or shake for dev menu',
+  android:
-  android: 'Double tap R on your keyboard to reload,\n' +
+    'Double tap R on your keyboard to reload,\n' +
     'Shake or press menu button for dev menu',
 });
 
-interface Props {};
+interface Props {}
-export default class App extends React.Component<Props> {
+export default class App extends Component<Props> {
   render() {
     return (
       <View style={styles.container}>
-        <Text style={styles.welcome}>
+        <Text style={styles.welcome}>Welcome to React Native!</Text>
-          Welcome to React Native!
+        <Text style={styles.instructions}>To get started, edit App.tsx</Text>
-        </Text>
+        <Text style={styles.instructions}>{instructions}</Text>
-        <Text style={styles.instructions}>
-          To get started, edit App.tsx
-        </Text>
-        <Text style={styles.instructions}>
-          {instructions}
-        </Text>
       </View>
     );
   }
@@ -57,4 +48,4 @@ const styles = StyleSheet.create({
     color: '#333333',
     marginBottom: 5,
   },
-});
+});

CONTRIBUTING.md

@@ -1,8 +1,6 @@
 # Contributing
 
-Cool, I'm glad you decided to contribute to React Native Template TypeScript.
+Contributing to this project should be as easy and transparent as possible.
-
-Don't worry, I won't bother you with thousands of rules. I want to make contributing to this project as easy and transparent as possible.
 
 ## Workflow
 
@@ -15,7 +13,3 @@ We use [GitHub Flow](https://guides.github.com/introduction/flow/), so all code
 ## License
 
 By contributing, you agree that your contributions will be licensed under the [MIT License](https://choosealicense.com/licenses/mit/).
-
-## Code style
-
-Currently there is no lint configuration, but you should try to stay consistent with the existing code.

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 Emin Khateeb
+Copyright (c) 2019 Emin Khateeb
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -1,51 +1,47 @@
-# :space_invader: React Native Template TypeScript · [![npm](https://img.shields.io/npm/v/react-native-template-typescript.svg)](https://www.npmjs.com/package/react-native-template-typescript) [![Travis](https://img.shields.io/travis/emin93/react-native-template-typescript.svg)](https://travis-ci.org/emin93/react-native-template-typescript)
+# :space_invader: React Native Template TypeScript · [![Build Status](https://travis-ci.org/emin93/react-native-template-typescript.svg?branch=master)](https://travis-ci.org/emin93/react-native-template-typescript)
 
 Clean and minimalist React Native template for a quick start with TypeScript.
 
 [![Header](https://cdn-images-1.medium.com/max/500/1*E9RnPOATuhjuNrlFkv5oSg.jpeg)](https://medium.com/@emin93/react-native-typescript-b965059109d3)
 
-This template can be used with the React Native CLI, which means it doesn't mess with the platform specific files. Instead of including a lot of dependencies, my aim when creating this template was to provide a very easy and minimalist way to start your React Native project with TypeScript. Of course you can always include other dependencies as you need them.
-
 ## :star: Features
 
--   Seamless integration with the React Native CLI! :sparkles:
+- Seamlessly integrated into the React Native CLI! :sparkles:
--   Consistent with the default React Native template (no additional stuff)
+- Consistent with the default React Native template
--   React Native TypeScript transformer directly integrated into the packager (no separate process for `tsc`)
+- Always latest dependencies :raised_hands:
--   Unit testing in TypeScript with TS Jest
--   Always latest dependencies :raised_hands:
 
 ## :arrow_forward: Quick Start
 
-```
+```bash
 react-native init MyApp --template typescript
-cd MyApp
-node setup.js
 ```
 
 ## :question: FAQ
 
-### What is included in this template?
+### What additional dependencies are included in this template?
 
--   [TypeScript](https://github.com/Microsoft/TypeScript)
+- [TypeScript](https://github.com/Microsoft/TypeScript)
--   [React Native TypeScript transformer](https://github.com/ds300/react-native-typescript-transformer)
+- [Type definitions for React & React Native](https://github.com/DefinitelyTyped/DefinitelyTyped)
--   [Type definitions for React & React Native](https://github.com/DefinitelyTyped/DefinitelyTyped)
--   [TS Jest](https://github.com/kulshekhar/ts-jest)
 
-This template always uses the latest versions of the dependencies at the time when the setup script (`node setup.js`) is being executed. This means you don't have to worry about old versions.
+This template always uses the latest versions of the dependencies at the time when the `react-native init` command is being executed. This means you don't have to worry about old versions.
 
 Lots of :heart: and credits to the owners and maintainers of those packages.
 
-### Why the setup script?
+### Does debugging work?
 
-The React Native CLI supports automatic installation of production dependencies only. Since TypeScript and the other dependencies are dev dependencies, the setup script is being used to install those. It also takes care of obsolete files like the `.flowconfig` and the `setup.js` itself after the setup.
+Yes it does. :tada:
 
-### How will this template affect the React Native CLI workflow?
+[![Demonstration of working breakpoints in Visual Studio Code](https://cdn-images-1.medium.com/max/1600/1*ZXfzgq1xKz1B3chYy9xE7w.png)](https://medium.com/@emin93/react-native-typescript-b965059109d3)
 
-The React Native CLI will do everything just as without a template and afterwards overwrite the files with the ones from this template. This means you don't have to worry about incompatibility issues with later React Native upgrades.
+### How to do type checking?
+
+`npx tsc`
 
 ## :globe_with_meridians: Links
 
--   ["Using React Native with TypeScript just became simple" on Medium](https://medium.com/@emin93/react-native-typescript-b965059109d3)
+- ["Using React Native with TypeScript just became simple" on Medium](https://medium.com/@emin93/react-native-typescript-b965059109d3)
+- ["24 tips for React Native you probably want to know" on Albert Gao's blog](http://albertgao.xyz/2018/05/30/24-tips-for-react-native-you-probably-want-to-know/#9-For-Typescript)
+- ["3 Easy Steps to Set Up React Native with TypeScript, Jest and Enzyme" on Medium by Jan Hesters](https://medium.com/@jan.hesters/3-easy-steps-to-set-up-react-native-with-typescript-jest-and-enzyme-592ca042262f)
 
 ## :computer: Contributing
 

__tests__/App-test.tsx

@@ -1,3 +1,7 @@
+/**
+ * @format
+ */
+
 import 'react-native';
 import React from 'react';
 import App from '../App';
@@ -6,7 +10,5 @@ import App from '../App';
 import renderer from 'react-test-renderer';
 
 it('renders correctly', () => {
-  const tree = renderer.create(
+  renderer.create(<App />);
-    <App />
+});
-  );
-});

_gitignore

@@ -0,0 +1,60 @@
+# OSX
+#
+.DS_Store
+
+# Xcode
+#
+build/
+*.pbxuser
+!default.pbxuser
+*.mode1v3
+!default.mode1v3
+*.mode2v3
+!default.mode2v3
+*.perspectivev3
+!default.perspectivev3
+xcuserdata
+*.xccheckout
+*.moved-aside
+DerivedData
+*.hmap
+*.ipa
+*.xcuserstate
+project.xcworkspace
+
+# Android/IntelliJ
+#
+build/
+.idea
+.gradle
+local.properties
+*.iml
+
+# Visual Studio Code
+#
+.vscode/
+
+# node.js
+#
+node_modules/
+npm-debug.log
+yarn-error.log
+
+# BUCK
+buck-out/
+\.buckd/
+*.keystore
+
+# fastlane
+#
+# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
+# screenshots whenever they are needed.
+# For more information about the recommended setup visit:
+# https://docs.fastlane.tools/best-practices/source-control/
+
+*/fastlane/report.xml
+*/fastlane/Preview.html
+*/fastlane/screenshots
+
+# Bundle artifact
+*.jsbundle

devDependencies.json

@@ -1,9 +1,7 @@
-[
+{
-    "@types/jest",
+  "@types/jest": "latest",
-    "@types/react",
+  "@types/react-native": "latest",
-    "@types/react-native",
+  "@types/react-test-renderer": "latest",
-    "@types/react-test-renderer",
+  "@types/react": "latest",
-    "react-native-typescript-transformer",
+  "typescript": "latest"
-    "ts-jest",
+}
-    "typescript"
-]

jest.config.js

@@ -0,0 +1,4 @@
+module.exports = {
+  preset: 'react-native',
+  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
+}

jest.json

@@ -1,15 +0,0 @@
-{
-    "transform": {
-        "^.+\\.tsx?$": "ts-jest"
-    },
-    "testRegex": "(/__tests__/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$",
-    "moduleFileExtensions": [
-        "ts",
-        "tsx",
-        "js",
-        "jsx",
-        "json",
-        "node"
-    ],
-    "modulePaths": ["<rootDir>"]
-}

package.json

@@ -1,25 +1,30 @@
 {
-    "name": "react-native-template-typescript",
+  "name": "react-native-template-typescript",
-    "version": "0.0.1",
+  "version": "0.0.1",
-    "description": "Clean and minimalist React Native template for a quick start with TypeScript.",
+  "description": "Clean and minimalist React Native template for a quick start with TypeScript.",
-    "scripts": {
+  "scripts": {
-        "prepublishOnly": "npm --no-git-tag-version version from-git"
+    "test": "standard setup.js",
-    },
+    "prepublishOnly": "npm --no-git-tag-version version $TRAVIS_TAG",
-    "repository": {
+    "install": "node setup.js"
-        "type": "git",
+  },
-        "url": "git+https://github.com/emin93/react-native-template-typescript.git"
+  "repository": {
-    },
+    "type": "git",
-    "keywords": [
+    "url": "git+https://github.com/emin93/react-native-template-typescript.git"
-        "react-native",
+  },
-        "typescript",
+  "keywords": [
-        "jest",
+    "react-native",
-        "template",
+    "typescript",
-        "boilerplate"
+    "jest",
-    ],
+    "template",
-    "author": "Emin Khateeb <emin@emin.ch>",
+    "boilerplate"
-    "license": "MIT",
+  ],
-    "bugs": {
+  "author": "Emin Khateeb <emin@emin.ch>",
-        "url": "https://github.com/emin93/react-native-template-typescript/issues"
+  "license": "MIT",
-    },
+  "bugs": {
-    "homepage": "https://github.com/emin93/react-native-template-typescript#readme"
+    "url": "https://github.com/emin93/react-native-template-typescript/issues"
+  },
+  "homepage": "https://github.com/emin93/react-native-template-typescript#readme",
+  "devDependencies": {
+    "standard": "12.0.1"
+  }
 }

rn-cli.config.js

@@ -1,8 +0,0 @@
-module.exports = {
-    getTransformModulePath() {
-        return require.resolve('react-native-typescript-transformer');
-    },
-    getSourceExts() {
-        return ['ts', 'tsx'];
-    }
-}

setup.js

@@ -1,56 +1,25 @@
-const fs = require('fs');
+const fs = require('fs')
-const path = require('path');
+const path = require('path')
-const { execSync } = require('child_process');
 
-const packageJson = require('./package.json');
+if (fs.existsSync(path.join(__dirname, '.travis.yml'))) {
-const jestConfig = require('./jest.json');
+  process.exit()
-const devDependencies = require('./devDependencies.json');
-
-const deleteFile = (fileName) => {
-    const filePath = path.join(process.cwd(), fileName);
-
-    if (!fs.existsSync(filePath)) {
-        return;
-    }
-
-    fs.unlinkSync(filePath);
-};
-const writeFile = (fileName, data) => fs.writeFileSync(path.join(process.cwd(), fileName), data);
-const isYarnAvailable = () => {
-    try {
-        execSync('yarn --version', { stdio: 'ignore' });
-        return true;
-    } catch (exc) {
-        return false;
-    }
-};
-
-const packageManager = isYarnAvailable() ? 'yarn' : 'npm';
-const execOptions = { stdio: 'inherit' };
-
-console.log('🔄 Please wait...\n');
-
-packageJson.scripts.start = `${packageJson.scripts.start} --config ../../../../rn-cli.config.js`;
-packageJson.jest = Object.assign(packageJson.jest, jestConfig);
-writeFile('package.json', JSON.stringify(packageJson, null, 2));
-
-console.log(`📦 Installing dependencies with ${packageManager}...\n`);
-
-switch (packageManager) {
-    case 'yarn':
-        execSync(`yarn add ${devDependencies.join(' ')} --dev --exact`, execOptions);
-        break;
-    default:
-        execSync(`npm i ${devDependencies.join(' ')} --save-dev --save-exact`, execOptions);
 }
 
-deleteFile('App.js');
+const projectFilesToDelete = ['.flowconfig', 'App.js', '__tests__/App-test.js']
-deleteFile('__tests__/App.js');
-deleteFile('.flowconfig');
-deleteFile('devDependencies.json');
-deleteFile('jest.json');
-deleteFile('README.md');
-deleteFile('LICENSE');
-deleteFile('setup.js');
 
-console.log(`\n✅ Setup completed! You can now start with: ${packageManager} start\n`);
+const templateFilesToDelete = ['setup.js', 'README.md', 'LICENSE']
+
+const deleteFile = filePath => {
+  if (!fs.existsSync(filePath)) {
+    return
+  }
+
+  fs.unlinkSync(filePath)
+}
+
+const projectPath = path.join(__dirname, '..', '..')
+const deleteProjectFile = fileName => deleteFile(path.join(projectPath, fileName))
+const deleteTemplateFile = fileName => deleteFile(path.join(__dirname, fileName))
+
+projectFilesToDelete.forEach(deleteProjectFile)
+templateFilesToDelete.forEach(deleteTemplateFile)

tsconfig.json

@@ -1,14 +1,15 @@
 {
-    "compilerOptions": {
+  "compilerOptions": {
-        "target": "es2015",
+    "allowJs": true,
-        "jsx": "react",
+    "allowSyntheticDefaultImports": true,
-        "noEmit": true,
+    "esModuleInterop": true,
-        "moduleResolution": "node",
+    "isolatedModules": true,
-        "noImplicitAny": true,
+    "jsx": "react",
-        "allowSyntheticDefaultImports": true,
+    "lib": ["es6"],
-        "esModuleInterop": true
+    "moduleResolution": "node",
-    },
+    "noEmit": true,
-    "exclude": [
+    "strict": true,
-        "node_modules"
+    "target": "esnext"
-    ]
+  },
+  "exclude": ["node_modules", "babel.config.js", "metro.config.js", "jest.config.js"]
 }