From 931102ff26ac76ffdd72ec303861fcf266f5c04d Mon Sep 17 00:00:00 2001 From: Stian Thorgersen Date: Mon, 7 Sep 2015 10:08:32 +0200 Subject: [PATCH] KEYCLOAK-1808 Revoke Grant button should disappear --- .../src/main/resources/theme/base/account/applications.ftl | 2 +- .../java/org/keycloak/testsuite/oauth/OAuthGrantTest.java | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/forms/common-themes/src/main/resources/theme/base/account/applications.ftl b/forms/common-themes/src/main/resources/theme/base/account/applications.ftl index 27b916b363..4e01c02d64 100755 --- a/forms/common-themes/src/main/resources/theme/base/account/applications.ftl +++ b/forms/common-themes/src/main/resources/theme/base/account/applications.ftl @@ -76,7 +76,7 @@ - <#if application.client.consentRequired> + <#if application.client.consentRequired && application.claimsGranted?has_content> diff --git a/testsuite/integration/src/test/java/org/keycloak/testsuite/oauth/OAuthGrantTest.java b/testsuite/integration/src/test/java/org/keycloak/testsuite/oauth/OAuthGrantTest.java index 5b71fd5bec..236330559e 100755 --- a/testsuite/integration/src/test/java/org/keycloak/testsuite/oauth/OAuthGrantTest.java +++ b/testsuite/integration/src/test/java/org/keycloak/testsuite/oauth/OAuthGrantTest.java @@ -49,6 +49,7 @@ import org.keycloak.testsuite.pages.OAuthGrantPage; import org.keycloak.testsuite.rule.KeycloakRule; import org.keycloak.testsuite.rule.WebResource; import org.keycloak.testsuite.rule.WebRule; +import org.openqa.selenium.By; import org.openqa.selenium.WebDriver; import java.io.IOException; @@ -130,10 +131,15 @@ public class OAuthGrantTest { events.expectCodeToToken(codeId, loginEvent.getSessionId()).client("third-party").assertEvent(); accountAppsPage.open(); + + assertEquals(1, driver.findElements(By.id("revoke-third-party")).size()); + accountAppsPage.revokeGrant("third-party"); events.expect(EventType.REVOKE_GRANT) .client("account").detail(Details.REVOKED_CLIENT, "third-party").assertEvent(); + + assertEquals(0, driver.findElements(By.id("revoke-third-party")).size()); } @Test