From 24babbae029ed353b4e4f287fc2ab2c140024325 Mon Sep 17 00:00:00 2001 From: Pablo Fernandez Date: Sun, 25 Sep 2011 16:37:49 -0300 Subject: [PATCH] better error messages when scribe can't establish a network connection --- src/main/java/org/scribe/model/Request.java | 9 +++++++-- src/main/java/org/scribe/model/Response.java | 5 +++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/scribe/model/Request.java b/src/main/java/org/scribe/model/Request.java index f40794d..4a68b91 100644 --- a/src/main/java/org/scribe/model/Request.java +++ b/src/main/java/org/scribe/model/Request.java @@ -59,9 +59,14 @@ class Request { createConnection(); return doSend(); - } catch (IOException ioe) + } + catch (UnknownHostException uhe) { - throw new OAuthException("Problems while creating connection", ioe); + throw new OAuthException("Could not reach the desired host. Check your network connection.", uhe); + } + catch (IOException ioe) + { + throw new OAuthException("Problems while creating connection.", ioe); } } diff --git a/src/main/java/org/scribe/model/Response.java b/src/main/java/org/scribe/model/Response.java index 6164e14..1ac91d4 100644 --- a/src/main/java/org/scribe/model/Response.java +++ b/src/main/java/org/scribe/model/Response.java @@ -28,10 +28,11 @@ public class Response code = connection.getResponseCode(); headers = parseHeaders(connection); stream = wasSuccessful() ? connection.getInputStream() : connection.getErrorStream(); - } catch (UnknownHostException e) + } + catch (UnknownHostException e) { code = 404; - body = EMPTY; + body = Response.EMPTY; } }