From 4f23cfaf20bc622f4a8ccf679e54a0bde3d75330 Mon Sep 17 00:00:00 2001 From: Stuart Grimshaw Date: Mon, 14 Mar 2011 23:41:34 +0000 Subject: [PATCH] Moved callback header above call to addOAthParams so it gets properly signed. --- changelog.txt | 6 +++++- pom.xml | 2 +- src/main/java/org/scribe/oauth/OAuth10aServiceImpl.java | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/changelog.txt b/changelog.txt index 4bd9c24..e503311 100644 --- a/changelog.txt +++ b/changelog.txt @@ -30,4 +30,8 @@ * FIX: Removed isEmpty() from OAuth2.0 code in order to support older JVMs * FEATURE: Overloaded provider() method to support instances as well as classes (thanks dustismo) * FIX: White-space parameter bug (thanks Krogoth) - * FEATURE: OAuth 2.0 now implements server-flow (thanks Diego Silveira) \ No newline at end of file + * FEATURE: OAuth 2.0 now implements server-flow (thanks Diego Silveira) + +[1.1.2] + + * FIX: Fixed ugly bug that made 1.1.1 practically unusable (thanks Stubbs) diff --git a/pom.xml b/pom.xml index 95da596..200f92d 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ org.scribe scribe jar - 1.1.1 + 1.1.2 Scribe OAuth Library The best OAuth library out there http://github.com/fernandezpablo85/scribe-java diff --git a/src/main/java/org/scribe/oauth/OAuth10aServiceImpl.java b/src/main/java/org/scribe/oauth/OAuth10aServiceImpl.java index ff5db09..db182e2 100644 --- a/src/main/java/org/scribe/oauth/OAuth10aServiceImpl.java +++ b/src/main/java/org/scribe/oauth/OAuth10aServiceImpl.java @@ -36,8 +36,8 @@ public class OAuth10aServiceImpl implements OAuthService public Token getRequestToken() { OAuthRequest request = new OAuthRequest(api.getRequestTokenVerb(), api.getRequestTokenEndpoint()); - addOAuthParams(request, OAuthConstants.EMPTY_TOKEN); request.addOAuthParameter(OAuthConstants.CALLBACK, config.getCallback()); + addOAuthParams(request, OAuthConstants.EMPTY_TOKEN); addOAuthHeader(request); Response response = request.send(); return api.getRequestTokenExtractor().extract(response.getBody());