From 6cfdf973f8918e5e8d8874d57358dc6237efc2f0 Mon Sep 17 00:00:00 2001 From: Pablo Fernandez Date: Wed, 28 Dec 2011 11:45:45 -0300 Subject: [PATCH] relaxed restrictions on OAuth callbacks --- src/main/java/org/scribe/builder/ServiceBuilder.java | 2 +- src/test/java/org/scribe/builder/ServiceBuilderTest.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/scribe/builder/ServiceBuilder.java b/src/main/java/org/scribe/builder/ServiceBuilder.java index b6d3c2c..27f3c8f 100644 --- a/src/main/java/org/scribe/builder/ServiceBuilder.java +++ b/src/main/java/org/scribe/builder/ServiceBuilder.java @@ -84,7 +84,7 @@ public class ServiceBuilder */ public ServiceBuilder callback(String callback) { - Preconditions.checkValidOAuthCallback(callback, "Callback must be a valid URL or 'oob'"); + Preconditions.checkNotNull(callback, "Callback can't be null"); this.callback = callback; return this; } diff --git a/src/test/java/org/scribe/builder/ServiceBuilderTest.java b/src/test/java/org/scribe/builder/ServiceBuilderTest.java index 75a6061..8112d79 100644 --- a/src/test/java/org/scribe/builder/ServiceBuilderTest.java +++ b/src/test/java/org/scribe/builder/ServiceBuilderTest.java @@ -46,9 +46,9 @@ public class ServiceBuilderTest } @Test(expected=IllegalArgumentException.class) - public void shouldNotAcceptAnInvalidUrlAsCallback() + public void shouldNotAcceptNullAsCallback() { - builder.provider(ApiMock.class).apiKey("key").apiSecret("secret").callback("example.com").build(); + builder.provider(ApiMock.class).apiKey("key").apiSecret("secret").callback(null).build(); } @Test